Skip to content

Clean up org pages layout#37445

Merged
silverwind merged 6 commits intogo-gitea:mainfrom
wxiaoguang:fix-teams-layout
Apr 27, 2026
Merged

Clean up org pages layout#37445
silverwind merged 6 commits intogo-gitea:mainfrom
wxiaoguang:fix-teams-layout

Conversation

@wxiaoguang
Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang commented Apr 27, 2026

  1. Fix overview sidebar regression
  2. Remove unnecessary classes and styles
  3. Fix "org invite" page

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 27, 2026
@wxiaoguang
Copy link
Copy Markdown
Contributor Author

wxiaoguang commented Apr 27, 2026

overview sidebar image
org invite image
org header image
org team sidebar image image

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2026
Comment thread templates/org/home.tmpl Outdated
</div>
<div class="ui attached table segment teams">
<div class="ui attached segment">
<div class="ui relaxed list">
Copy link
Copy Markdown
Member

@silverwind silverwind Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is time to stop introducing new fomantic classes and either use tailwind or some other helpers. Eventually I want to get rid of all ui and this will make it harder.

@silverwind
Copy link
Copy Markdown
Member

#37446 regarding apparant flaky test.

@wxiaoguang wxiaoguang changed the title Fix org sidebar layout Clean up org pages layout Apr 27, 2026
@silverwind silverwind requested a review from Copilot April 27, 2026 12:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors organization-related page layouts by removing legacy/org-specific CSS and updating org templates to use shared flex utility classes, while also adjusting the team invite and team sidebar markup.

Changes:

  • Removed legacy repoorg.css styling and pruned org-specific CSS rules from org.css.
  • Updated org templates (org header, org home sidebar, team sidebar, team invite) to use shared flex layout helpers (flex-left-right, flex-relaxed-list, flex-text-block) and simpler segment structure.
  • Added a commented-out debug stub in the org teams router (currently left in the code).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
web_src/css/shared/repoorg.css Removed legacy repo/org header + tabs layout rules.
web_src/css/org.css Removed org header/invite/teams navbar CSS that no longer matches updated markup.
web_src/css/index.css Dropped import of the removed repoorg.css.
templates/org/team/sidebar.tmpl Replaced “table segment + item” structure with stacked attached segments and new flex header layout.
templates/org/team/invite.tmpl Reworked invite page markup to a centered flex layout instead of a Semantic UI card.
templates/org/home.tmpl Updated members/teams sidebar blocks to use flex-left-right headers and flex-relaxed-list content layout.
templates/org/header.tmpl Refactored org header markup to new shared flex layout helpers and removed old id/class hooks.
routers/web/org/teams.go Added commented-out debug assignment lines in TeamInvite.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread routers/web/org/teams.go
Comment thread templates/org/team/invite.tmpl Outdated
Comment thread templates/org/home.tmpl Outdated
Comment thread templates/org/team/sidebar.tmpl Outdated
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 27, 2026
@bircni bircni requested a review from silverwind April 27, 2026 19:52
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2026
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2026
@silverwind silverwind enabled auto-merge (squash) April 27, 2026 22:50
@silverwind silverwind merged commit 4952a48 into go-gitea:main Apr 27, 2026
26 checks passed
@GiteaBot GiteaBot added this to the 1.27.0 milestone Apr 27, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2026
@wxiaoguang wxiaoguang deleted the fix-teams-layout branch April 28, 2026 03:57
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 29, 2026
* main:
  Add DEFAULT_TITLE_SOURCE setting for pull request title default behavior (go-gitea#37465)
  Fix compare dropdown for branches without common history (go-gitea#37470)
  FIX: URL sanitization to handle schemeless credentials (go-gitea#37440)
  Refactor pull request view (4) (go-gitea#37451)
  Fix scheduled action panic with null event payload (go-gitea#37459)
  Fix attachment Content-Security-Policy (go-gitea#37455)
  [skip ci] Updated translations via Crowdin
  Rename CurrentRefPath to CurrentRefSubURL (go-gitea#37453)
  Clean up org pages layout (go-gitea#37445)
  Fix script error alert (go-gitea#37458)
  Fix inconsistent disabled styling on logged-out repo header buttons (go-gitea#37406)
  Add API endpoint to reply to pull request review comments (go-gitea#36683)
  Add CurrentURL template variable back (go-gitea#37444)
wxiaoguang added a commit that referenced this pull request May 2, 2026
Purpose:

1. Make the whole code base have unified "item" layout
2. Clarify our "list" styles: "flex-relaxed-list", "flex-divided-list"
3. Prepare to replace legacy "ui relaxed list"
* #37445 (comment)
4. Prepare for refactoring the "pull merge box", it needs the
"flex-divided-list"
    * related to "Refactor pull request view (*)" like #37451
5. Fix legacy abuses of "flex-list", e.g.: repo home sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants